> -----Original Message----- > From: Ioana Ciornei <[email protected]> > Sent: Monday, November 9, 2020 17:46 > To: [email protected]; [email protected] > Cc: Ioana Ciornei <[email protected]> > Subject: [PATCH net-next] net: phy: aquantia: do not return an error on > clearing pending IRQs > > From: Ioana Ciornei <[email protected]> > > The referenced commit added in .config_intr() the part of code which upon > configuration of the IRQ state it also clears up any pending IRQ. If > there were actually pending IRQs, a read on the IRQ status register will > return something non zero. This should not result in the callback > returning an error. > > Fix this by returning an error only when the result of the > phy_read_mmd() is negative. > > Fixes: e11ef96d44f1 ("net: phy: aquantia: remove the use of > .ack_interrupt()") > Signed-off-by: Ioana Ciornei <[email protected]>
I ran into this issue recently. Thanks for the fix. Tested-by: Camelia Groza <[email protected]>
