On 11/10/20 11:35 AM, Jiri Olsa wrote:
On Mon, Nov 09, 2020 at 11:04:34PM +0100, Daniel Borkmann wrote:
SNIP
index 7b53cb3092ee..a7c71e3b5f9a 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -52,6 +52,7 @@
#define __initconst __section(".init.rodata")
#define __exitdata __section(".exit.data")
#define __exit_call __used __section(".exitcall.exit")
+#define __init_bpf_preserve_type __section(".init.bpf.preserve_type")
Small nit, why this detour via BPF_INIT define? Couldn't we just:
#ifdef CONFIG_DEBUG_INFO_BTF
#define __init_bpf_preserve_type __section(".init.bpf.preserve_type")
#else
#define __init_bpf_preserve_type __init
#endif
Also, the comment above the existing defines says '/* These are for everybody
(although
not all archs will actually discard it in modules) */' ... We should probably
not add
the __init_bpf_preserve_type right under this listing as-is in your patch, but
instead
'separate' it by adding a small comment on top of its definition by explaining
its
purpose more clearly for others.
ok, for some reason I thought I needed to add it to init.h,
but as it's bpf specific, perhaps we can omit init.h change
completely.. how about the change below?
Agree, that looks much better, thanks!
