On Tue, 10 Nov 2020 10:37:11 +0530 Vinay Kumar Yadav wrote: > It is not incompatible. It fits in k.org tls infrastructure (TLS-TOE > mode). For the current issue we have proposed a fix. What is the issue > with proposed fix, can you elaborate and we will address that?
Your lack of understanding of how netdev offloads are supposed to work is concerning. Application is not supposed to see any difference between offloaded and non-offloaded modes of operation. Your offload was accepted based on the assumption that it works like the software kernel TLS mode. Nobody had the time to look at your thousands lines of driver code at the time. Now you're telling us that the uAPI for the offload is completely different - it only works on listening sockets while software tls only works on established sockets. Ergo there is no software fallback for your offload. Furthermore the severity of the bugs you just started to fix now, after the code has been in the kernel for over a year suggests there are no serious users and we can just remove this code.
