in addition to Jakub's comments ...

On 11/8/20 7:50 PM, Jeff Dike wrote:
> @@ -1706,6 +1708,11 @@ static void pndisc_redo(struct sk_buff *skb)
>       kfree_skb(skb);
>  }
>  
> +static int ndisc_is_multicast(const void *pkey)
> +{
> +     return (((struct in6_addr *)pkey)->in6_u.u6_addr8[0] & 0xf0) == 0xf0;

ipv6_addr_type() and IPV6_ADDR_MULTICAST is the better way to code this.



> +}
> +
>  static bool ndisc_suppress_frag_ndisc(struct sk_buff *skb)
>  {
>       struct inet6_dev *idev = __in6_dev_get(skb->dev);
> 

Reply via email to