On 2020/11/8 16:20, Tariq Toukan wrote:
>
>
> On 11/7/2020 8:53 AM, xiakaixu1...@gmail.com wrote:
>> From: Kaixu Xia <kaixu...@tencent.com>
>>
>> Fix the following coccinelle warnings:
>>
>
> Hi Kaixu,
>
> Which coccinelle version gave this warning?
Hi Tariq,
The version is coccinelle-1.0.7.
Thanks,
Kaixu
>
>
>> ./drivers/net/ethernet/mellanox/mlx4/en_rx.c:687:1-17: WARNING: Assignment
>> of 0/1 to bool variable
>>
>> Reported-by: Tosk Robot <tencent_os_ro...@tencent.com>
>> Signed-off-by: Kaixu Xia <kaixu...@tencent.com>
>> ---
>> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
>> b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
>> index 502d1b97855c..b0f79a5151cf 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
>> @@ -684,7 +684,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct
>> mlx4_en_cq *cq, int bud
>> xdp_prog = rcu_dereference(ring->xdp_prog);
>> xdp.rxq = &ring->xdp_rxq;
>> xdp.frame_sz = priv->frag_info[0].frag_stride;
>> - doorbell_pending = 0;
>> + doorbell_pending = false;
>> /* We assume a 1:1 mapping between CQEs and Rx descriptors, so Rx
>> * descriptor offset can be deduced from the CQE index instead of
>>
>
--
kaixuxia
