On Thu, Nov 5, 2020 at 7:13 PM Alexei Starovoitov
<alexei.starovoi...@gmail.com> wrote:
>
> On Wed, Nov 04, 2020 at 08:51:38PM -0800, Andrii Nakryiko wrote:
> >
> > +config DEBUG_INFO_BTF_MODULES
> > +     bool "Generate BTF for kernel modules"
> > +     def_bool y
> > +     depends on DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SPLIT_BTF
>
> Does it need to be a new config ?
> Can the build ran pahole if DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SPLIT_BTF 
> ?

It probably doesn't. If I drop the "bool" line, it will become
non-configurable calculated Kconfig value, convenient to use
everywhere. All the rest will stay exactly the same. It's nice to not
have to do "if defined(DEBUG_INFO_BTF) && defined(MODULES) &&
defined(PAHOLE_HAS_SPLIT_BTF)" checks, but rather a simple "ifdef
CONFIG_DEBUG_INFO_BTF_MODULES". Does that work?

Reply via email to