Re: [PATCH bpf-next 05/11] selftests/bpf: add split BTF basic test

[Song Liu]

> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko <and...@kernel.org> wrote:
> 
> Add selftest validating ability to programmatically generate and then dump
> split BTF.
> 
> Signed-off-by: Andrii Nakryiko <and...@kernel.org>

Acked-by: Song Liu <songliubrav...@fb.com>

With a nit:

[...]
> 
> +
> +static void btf_dump_printf(void *ctx, const char *fmt, va_list args)
> +{
> +     vfprintf(ctx, fmt, args);
> +}
> +
> +void test_btf_split() {
> +     struct btf_dump_opts opts;
> +     struct btf_dump *d = NULL;
> +     const struct btf_type *t;
> +     struct btf *btf1, *btf2 = NULL;

No need to initialize btf2 to NULL. 

> +     int str_off, i, err;
> +
> +     btf1 = btf__new_empty();
> +     if (!ASSERT_OK_PTR(btf1, "empty_main_btf"))
> +             return;
> +
> 

[...]