> -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: Saturday, October 31, 2020 03:44 > To: Camelia Alexandra Groza <camelia.gr...@nxp.com> > Cc: willemdebruijn.ker...@gmail.com; Madalin Bucur (OSS) > <madalin.bu...@oss.nxp.com>; da...@davemloft.net; > netdev@vger.kernel.org > Subject: Re: [PATCH net v2 2/2] dpaa_eth: fix the RX headroom size > alignment > > On Wed, 28 Oct 2020 18:41:00 +0200 Camelia Groza wrote: > > @@ -2842,7 +2842,8 @@ static int dpaa_ingress_cgr_init(struct dpaa_priv > *priv) > > return err; > > } > > > > -static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl) > > +static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl, > > + enum port_type port) > > Please drop the "inline" while you're touching this definition. > > The compiler will make the right inlining decision here.
Sure, I'll drop it.
