Re: [PATCH net-next] net: sched: implement action-specific terse dump

[Jamal Hadi Salim]

Thanks Vlad. Ive run the basic test and it looks good.
One thing i discovered while testing is that if the
cookie is set, we also want it in the dump. Your earlier
comment that it only costs if it was set is on point.

So please remove that check below:


> +  if (cookie && !from_act) {
> +          if (nla_put(skb, TCA_ACT_COOKIE, cookie->len, cookie->data)) {
> +                  rcu_read_unlock();
> +                  goto nla_put_failure;
> +          }


cheers,
jamal