On Thu, Apr 26, 2007 at 09:46:32AM -0700, Jean Tourrilhes wrote: > Overall ok with the patches. Comments on a few of them... > I personally would not remove this DEBUG code, because it > decreases the overall maitainability of the code. > First, it does not only help to debug the API, but it can be > used to debug userspace and drivers in some extreme cases. > Second, this debugging act as documentation. He points out > which are the important variables and how they are used at critical > points of the code. > As this debug is localised, and compiled out, it does not > bother anybody and should stay.
Jean, I think the code looks cleaner with the patch applied. If the debugging is valuable to you, I recommend that you save this patch and reverse apply it before future work. Thanks, John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
