Hi Hayes,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on net-next/master ipvs/master linus/master v5.10-rc1 
next-20201029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Hayes-Wang/net-usb-r8153_ecm-support-ECM-mode-for-RTL8153/20201029-203440
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 
d6535dca28859d8d9ef80894eb287b2ac35a32e8
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/e34498795de95fbccb0f2feee72cd8df723f9fd3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Hayes-Wang/net-usb-r8153_ecm-support-ECM-mode-for-RTL8153/20201029-203440
        git checkout e34498795de95fbccb0f2feee72cd8df723f9fd3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross 
ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/usb/r8152.c:6618:4: warning: no previous prototype for 
>> 'rtl8152_get_version' [-Wmissing-prototypes]
    6618 | u8 rtl8152_get_version(struct usb_interface *intf)
         |    ^~~~~~~~~~~~~~~~~~~

vim +/rtl8152_get_version +6618 drivers/net/usb/r8152.c

  6617  
> 6618  u8 rtl8152_get_version(struct usb_interface *intf)
  6619  {
  6620          struct usb_device *udev = interface_to_usbdev(intf);
  6621          u32 ocp_data = 0;
  6622          __le32 *tmp;
  6623          u8 version;
  6624          int ret;
  6625  
  6626          tmp = kmalloc(sizeof(*tmp), GFP_KERNEL);
  6627          if (!tmp)
  6628                  return 0;
  6629  
  6630          ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
  6631                                RTL8152_REQ_GET_REGS, RTL8152_REQT_READ,
  6632                                PLA_TCR0, MCU_TYPE_PLA, tmp, 
sizeof(*tmp), 500);
  6633          if (ret > 0)
  6634                  ocp_data = (__le32_to_cpu(*tmp) >> 16) & VERSION_MASK;
  6635  
  6636          kfree(tmp);
  6637  
  6638          switch (ocp_data) {
  6639          case 0x4c00:
  6640                  version = RTL_VER_01;
  6641                  break;
  6642          case 0x4c10:
  6643                  version = RTL_VER_02;
  6644                  break;
  6645          case 0x5c00:
  6646                  version = RTL_VER_03;
  6647                  break;
  6648          case 0x5c10:
  6649                  version = RTL_VER_04;
  6650                  break;
  6651          case 0x5c20:
  6652                  version = RTL_VER_05;
  6653                  break;
  6654          case 0x5c30:
  6655                  version = RTL_VER_06;
  6656                  break;
  6657          case 0x4800:
  6658                  version = RTL_VER_07;
  6659                  break;
  6660          case 0x6000:
  6661                  version = RTL_VER_08;
  6662                  break;
  6663          case 0x6010:
  6664                  version = RTL_VER_09;
  6665                  break;
  6666          default:
  6667                  version = RTL_VER_UNKNOWN;
  6668                  dev_info(&intf->dev, "Unknown version 0x%04x\n", 
ocp_data);
  6669                  break;
  6670          }
  6671  
  6672          dev_dbg(&intf->dev, "Detected version 0x%04x\n", version);
  6673  
  6674          return version;
  6675  }
  6676  EXPORT_SYMBOL_GPL(rtl8152_get_version);
  6677  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to