> What about reverting the realtek PHY commit from stable? > As Ard said it doesn't really fix anything (usage wise) and causes a bunch of > problems. > > If I understand correctly we have 3 options: > 1. 'Hack' the drivers in stable to fix it (and most of those hacks will take > a long time to remove) > 2. Update DTE of all affected devices, backport it to stable and force users > to > update > 3. Revert the PHY commit > > imho [3] is the least painful solution.
The PHY commit is correct, in that it fixes a bug. So i don't want to remove it. Backporting it to stable is what is causing most of the issues today, combined with a number of broken DT descriptions. So i would be happy for stable to get a patch which looks at the strapping, sees ID is enabled via strapping, warns the DT blob is FUBAR, and then ignores the requested PHY-mode. That gives developers time to fix their broken DT. Andrew