Re: [PATCH v5 1/3] net: phy: Add 5GBASER interface mode

[Andrew Lunn]

On Wed, Oct 28, 2020 at 10:08:27AM +1000, Pavana Sharma wrote:
> Add new mode supported by MV88E6393 family.
> 
> Signed-off-by: Pavana Sharma <pavana.sha...@digi.com>
> ---
>  include/linux/phy.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 3a09d2bf69ea..9de7c57cfd38 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -107,6 +107,7 @@ typedef enum {
>       PHY_INTERFACE_MODE_2500BASEX,
>       PHY_INTERFACE_MODE_RXAUI,
>       PHY_INTERFACE_MODE_XAUI,
> +     PHY_INTERFACE_MODE_5GBASER,
>       /* 10GBASE-R, XFI, SFI - single lane 10G Serdes */
>       PHY_INTERFACE_MODE_10GBASER,
>       PHY_INTERFACE_MODE_USXGMII,


Hi Pavana

You need to add this new mode to the kerneldoc above the
typedef. Otherwise you will get a warning from W=1 and kernel
documentation build process.

        Andrew