list_is_singular() can tell whether a list has just one entry.
So we use list_is_singular() here.

Signed-off-by: Hui Su <sh_...@163.com>
---
 net/atm/br2684.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index 3e17a5ecaa94..398f7e086cf4 100644
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -372,8 +372,7 @@ static int br2684_setfilt(struct atm_vcc *atmvcc, void 
__user * arg)
                struct br2684_dev *brdev;
                read_lock(&devs_lock);
                brdev = BRPRIV(br2684_find_dev(&fs.ifspec));
-               if (brdev == NULL || list_empty(&brdev->brvccs) ||
-                   brdev->brvccs.next != brdev->brvccs.prev)   /* >1 VCC */
+               if (brdev == NULL || !list_is_singular(&brdev->brvccs)) /* >1 
VCC */
                        brvcc = NULL;
                else
                        brvcc = list_entry_brvcc(brdev->brvccs.next);
-- 
2.25.1


Reply via email to