On Tue, Oct 20, 2020 at 10:03:00AM +0800, Jason Wang wrote:
>
> On 2020/10/19 下午5:07, we...@ucloud.cn wrote:
> > From: wenxu <we...@ucloud.cn>
> >
> > Qemu get virtio_net_config from the vdpa driver. So The vdpa driver
> > should set the VIRTIO_NET_S_LINK_UP flag to virtio_net_config like
> > vdpa_sim. Or the link of virtio net NIC in the virtual machine will
> > never up.
> >
> > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5
> > devices")
> > Signed-off-by: wenxu <we...@ucloud.cn>
> > ---
> > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > index 74264e59..af6c74c 100644
> > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > @@ -1537,6 +1537,8 @@ static int mlx5_vdpa_set_features(struct vdpa_device
> > *vdev, u64 features)
> > ndev->mvdev.actual_features = features & ndev->mvdev.mlx_features;
> > ndev->config.mtu = __cpu_to_virtio16(mlx5_vdpa_is_little_endian(mvdev),
> > ndev->mtu);
> > + ndev->config.status =
> > __cpu_to_virtio16(mlx5_vdpa_is_little_endian(mvdev),
> > + VIRTIO_NET_S_LINK_UP);
> > return err;
> > }
>
>
> Other than the small issue pointed out by Jakub.
>
> Acked-by: Jason Wang <jasow...@redhat.com>
>
>
I already posted a fix for this a while ago and Michael should merge it.
https://lkml.org/lkml/2020/9/17/543
