Il giorno 20/apr/07, alle ore 15:54, Neil Horman ha scritto:
Yes, I had one report of a user actually hitting this, but it is quite hard to reproduce and I don't have continuos access anymore to my sis900 machine.Hey there- The sis900 driver appears to have a bug in which the receive routinepasses the skbuff holding the received frame to the network stack before refilling the buffer in the rx ring. If a new skbuff cannot be allocated, the driver simply leaves a hole in the rx ring, which causes the driver to stop receiving frames and become non-recoverable without an rmmod/insmod according to reporters. This patch reverses that order, attempting to allocate a replacement buffer first, and receiving the new frame only if one can be allocated. If no skbuff can be allocated, the current skbuf in the rx ring is recycled, droppingthe current frame, but keeping the NIC operational.
The patch seems fine by me.
Signed-off-by: Neil Horman <[EMAIL PROTECTED]>
Signed-off-by: Daniele Venzano <[EMAIL PROTECTED]> -- Daniele Venzano http://www.brownhat.org
PGP.sig
Description: Questa รจ un messaggio firmato elettronicamente
