Hi Xin, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9faebeb2d80065926dfbc09cb73b1bb7779a89cd config: i386-randconfig-s002-20201008 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-218-gc0e96d6d-dirty # https://github.com/0day-ci/linux/commit/7dab31e8c96fab2089a651d5a6d06bcf92b011ad git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211 git checkout 7dab31e8c96fab2089a651d5a6d06bcf92b011ad # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> echo echo "sparse warnings: (new ones prefixed by >>)" echo >> net/sctp/sysctl.c:532:39: sparse: sparse: incorrect type in assignment >> (different base types) @@ expected restricted __be16 [usertype] udp_port >> @@ got int udp_port @@ >> net/sctp/sysctl.c:532:39: sparse: expected restricted __be16 [usertype] >> udp_port >> net/sctp/sysctl.c:532:39: sparse: got int udp_port vim +532 net/sctp/sysctl.c 500 501 static int proc_sctp_do_udp_port(struct ctl_table *ctl, int write, 502 void *buffer, size_t *lenp, loff_t *ppos) 503 { 504 struct net *net = current->nsproxy->net_ns; 505 unsigned int min = *(unsigned int *)ctl->extra1; 506 unsigned int max = *(unsigned int *)ctl->extra2; 507 struct ctl_table tbl; 508 int ret, new_value; 509 510 memset(&tbl, 0, sizeof(struct ctl_table)); 511 tbl.maxlen = sizeof(unsigned int); 512 513 if (write) 514 tbl.data = &new_value; 515 else 516 tbl.data = &net->sctp.udp_port; 517 518 ret = proc_dointvec(&tbl, write, buffer, lenp, ppos); 519 if (write && ret == 0) { 520 struct sock *sk = net->sctp.ctl_sock; 521 522 if (new_value > max || new_value < min) 523 return -EINVAL; 524 525 net->sctp.udp_port = new_value; 526 sctp_udp_sock_stop(net); 527 ret = sctp_udp_sock_start(net); 528 if (ret) 529 net->sctp.udp_port = 0; 530 531 lock_sock(sk); > 532 sctp_sk(sk)->udp_port = net->sctp.udp_port; 533 release_sock(sk); 534 } 535 536 return ret; 537 } 538 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
