From: Fabian Frederick <f...@skynet.be>

When some test directly done with check_one_counter() fails,
counter variable is undefined. This patch calls ip with cname
which avoids errors like:
FAIL: oskuidcounter, want "packets 2", got
Error: syntax error, unexpected newline, expecting string
list counter inet filter
                        ^
Error is now correctly rendered:
FAIL: oskuidcounter, want "packets 2", got
table inet filter {
        counter oskuidcounter {
                packets 1 bytes 84
        }
}

Signed-off-by: Fabian Frederick <f...@skynet.be>
Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org>
---
 tools/testing/selftests/netfilter/nft_meta.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/netfilter/nft_meta.sh 
b/tools/testing/selftests/netfilter/nft_meta.sh
index 17b2d6eaa204..1f5b46542c14 100755
--- a/tools/testing/selftests/netfilter/nft_meta.sh
+++ b/tools/testing/selftests/netfilter/nft_meta.sh
@@ -90,7 +90,7 @@ check_one_counter()
        if [ $? -ne 0 ];then
                echo "FAIL: $cname, want \"$want\", got"
                ret=1
-               ip netns exec "$ns0" nft list counter inet filter $counter
+               ip netns exec "$ns0" nft list counter inet filter $cname
        fi
 }
 
-- 
2.20.1

Reply via email to