On Thu, 01 Oct 2020 22:55:09 +0200 Johannes Berg wrote: > On Thu, 2020-10-01 at 11:30 -0700, Jakub Kicinski wrote: > > Wire up per-op policy for CTRL_CMD_GETPOLICY. > > This saves us a call to genlmsg_parse() and will soon allow > > dumping this policy. > > Hmm. Probably should've asked this before - I think the code makes > perfect sense, but I'm not sure how "this" follows? > > I mean, we could've saved the genlmsg_parse() call before, with much the > same patch, having the per-op policy doesn't really have any bearing for > that? It was just using a different policy - the family one - instead of > the per-op one, but ... > > Am I missing something?
Hm, not as far as I can tell, I was probably typing out the message fast cause the commit is kinda obivious. Looking at the code again now I can't tell why it was calling genlmsg_parse() in the first place. LMK if you remember if there was a reason. Otherwise I'll just reword.
