Re: RTL8402 stops working after hibernate/resume

[Petr Tesarik]

On Wed, 30 Sep 2020 17:47:15 +0200
Heiner Kallweit <hkallwe...@gmail.com> wrote:

>[...]
> Petr,
> in the following I send two patches. First one is supposed to fix the freeze.
> It also fixes another issue that existed before my ether_clk change:
> ether_clk was disabled on suspend even if WoL is enabled. And the network
> chip most likely needs the clock to check for WoL packets.
> Please let me know whether it fixes the freeze, then I'll add your Tested-by.
> 
> Second patch is a re-send of the one I sent before, it should fix
> the rx issues after resume from suspend for you.
> 
>[...]
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c 
> b/drivers/net/ethernet/realtek/r8169_main.c
> index 9e4e6a883..4fb49fd0d 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -4837,6 +4837,10 @@ static int rtl8169_resume(struct device *device)
>  
>       rtl_rar_set(tp, tp->dev->dev_addr);
>  
> +     /* Reportedly at least Asus X453MA corrupts packets otherwise */

Just a nitpick: The incoming packets are not corrupted, they are truncated:

+       /* Reportedly at least Asus X453MA truncates packets otherwise */

Other than that, like I have already written in another part of the thread:

Tested-by: Petr Tesarik <ptesa...@suse.com>

> +     if (tp->mac_version == RTL_GIGA_MAC_VER_37)
> +             rtl_init_rxcfg(tp);
> +
>       if (tp->TxDescArray)
>               rtl8169_up(tp);
>  
> -- 
> 2.28.0
> 

pgpw21IuAJxhk.pgp
Description: Digitální podpis OpenPGP