From: Jakub Kicinski <k...@kernel.org> Date: Fri, 25 Sep 2020 18:56:04 -0700
> This reverts commit 546c044c9651e81a16833806feff6b369bb5de33. > > Nothing prevents user from sending frames to "external" VxLAN devices. > In fact kernel itself may generate icmp chatter. > > This is fine, such frames should be dropped. > > The point of the "missing encapsulation" warning was that > frames with missing encap should not make it into vxlan_xmit_one(). > And vxlan_xmit() drops them cleanly, so let it just do that. > > Without this revert the warning is triggered by the udp_tunnel_nic.sh > test, but the minimal repro is: > > $ ip link add vxlan0 type vxlan \ > group 239.1.1.1 \ > dev lo \ > dstport 1234 \ > external > $ ip li set dev vxlan0 up > > [ 419.165981] vxlan0: Missing encapsulation instructions > [ 419.166551] WARNING: CPU: 0 PID: 1041 at drivers/net/vxlan.c:2889 > vxlan_xmit+0x15c0/0x1fc0 [vxlan] > > Signed-off-by: Jakub Kicinski <k...@kernel.org> Applied, thanks Jakub.
