> static int rtl8366rb_setup(struct dsa_switch *ds)
> {
> struct realtek_smi *smi = ds->priv;
> + struct rtl8366rb *rb = smi->chip_data;
> const u16 *jam_table;
> u32 chip_ver = 0;
> u32 chip_id = 0;
Hi Linus
Reverse Christmas tree means you need to do the assignment later.
Otherwise this looks O.K.
Andrew
