Re: [PATCH 2/3] gve: Add support for raw addressing to the rx path

[David Miller]

From: David Awogbemila <awogbem...@google.com>
Date: Fri, 18 Sep 2020 11:07:19 -0700

> @@ -514,11 +516,11 @@ int gve_adminq_describe_device(struct gve_priv *priv)
>       mac = descriptor->mac;
>       dev_info(&priv->pdev->dev, "MAC addr: %pM\n", mac);
>       priv->tx_pages_per_qpl = be16_to_cpu(descriptor->tx_pages_per_qpl);
> -     priv->rx_pages_per_qpl = be16_to_cpu(descriptor->rx_pages_per_qpl);
> -     if (priv->rx_pages_per_qpl < priv->rx_desc_cnt) {
> -             dev_err(&priv->pdev->dev, "rx_pages_per_qpl cannot be smaller 
> than rx_desc_cnt, setting rx_desc_cnt down to %d.\n",
> -                       priv->rx_pages_per_qpl);
> -             priv->rx_desc_cnt = priv->rx_pages_per_qpl;
> +     priv->rx_data_slot_cnt = be16_to_cpu(descriptor->rx_pages_per_qpl);
> +     if (priv->rx_data_slot_cnt < priv->rx_desc_cnt) {
> +             dev_err(&priv->pdev->dev, "rx_data_slot_cnt cannot be smaller 
> than rx_desc_cnt, setting rx_desc_cnt down to %d.\n",
> +                     priv->rx_data_slot_cnt);
> +             priv->rx_desc_cnt = priv->rx_data_slot_cnt;

I find it funny that the indentation of the second line of the dev_err()
call here is broken in patch #1 and then fixed back up here in patch #2

Please eliminate this unnecessary noise, thank you.