> On Mon, Apr 09, 2007 at 02:28:41PM -0700, Peter P Waskiewicz
> Jr ([EMAIL PROTECTED]) wrote:
> > + alloc_size = (sizeof(struct net_device_subqueue) * queue_count);
> > +
> > + p = kzalloc(alloc_size, GFP_KERNEL);
> > + if (!p) {
> > + printk(KERN_ERR "alloc_netdev: Unable to
> allocate queues.\n");
> > + return NULL;
>
> I think you either do not want to print it, or want
> additional details about device...
Ok. This is essentially the same output printed if the netdev itself
cannot be allocated. Should I update both strings to have more
device-specific information?
>
> > + }
> > +
> > + dev->egress_subqueue = p;
> > + dev->egress_subqueue_count = queue_count;
> > +
> > dev->get_stats = maybe_internal_stats;
> > setup(dev);
> > strcpy(dev->name, name);
> > return dev;
> > }
> > -EXPORT_SYMBOL(alloc_netdev);
> > +EXPORT_SYMBOL(alloc_netdev_mq);
> >
> > /**
> > * free_netdev - free network device
> > @@ -3345,6 +3358,7 @@ void free_netdev(struct net_device *dev) {
> > #ifdef CONFIG_SYSFS
> > /* Compatibility with error handling in drivers */
> > + kfree((char *)dev->egress_subqueue);
> > if (dev->reg_state == NETREG_UNINITIALIZED) {
> > kfree((char *)dev - dev->padded);
> > return;
> > @@ -3356,6 +3370,7 @@ void free_netdev(struct net_device *dev)
> > /* will free via device release */
> > put_device(&dev->dev);
> > #else
> > + kfree((char *)dev->egress_subqueue);
>
> Still casting :)
The latest repost removes these casts.
Thanks for the feedback,
-PJ Waskiewicz
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
