From: Florian Fainelli <f.faine...@gmail.com> Date: Thu, 17 Sep 2020 17:18:42 -0700
> > > On 9/17/2020 4:40 PM, David Miller wrote: >> From: Florian Fainelli <f.faine...@gmail.com> >> Date: Wed, 16 Sep 2020 13:44:14 -0700 >> >>> @@ -160,6 +160,7 @@ static int unimac_mdio_reset(struct mii_bus *bus) >>> { >>> struct device_node *np = bus->dev.of_node; >>> struct device_node *child; >>> + struct clk *clk; >>> u32 read_mask = 0; >>> int addr; >> Please preserve the reverse christmas tree ordering of these local >> variables, thank you. > > Looks like I used the same thread for all patches, the most recent is > this one: > > https://patchwork.ozlabs.org/project/netdev/patch/20200917020413.2313461-1-f.faine...@gmail.com/ > > and is the one I would like to see you apply if you are happy with it. Ok I'll just give Andrew a chance to reply to your most recent comment in that thread.