On Fri, 28 Aug 2020 18:48:25 +0100 Edward Cree wrote: > A collection of minor fixes to issues flagged up by W=1. > After this series, the only remaining warnings in the sfc driver are > some 'member missing in kerneldoc' warnings from ptp.c. > Tested by building on x86_64 and running 'ethtool -p' on an EF10 NIC; > there was no error, but I couldn't observe the actual LED as I'm > working remotely.
LGTM, although borderline net if you ask me. Reviewed-by: Jakub Kicinski <k...@kernel.org> > [ Incidentally, ethtool_phys_id()'s behaviour on an error return > looks strange — if I'm reading it right, it will break out of the > inner loop but not the outer one, and eventually return the rc > from the last run of the inner loop. Is this intended? ] I think you're right. Care to fix?
