This series introduces support for a new attribute to the flash update command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK.
This attribute is a bitfield which allows userspace to specify what set of subfields to overwrite when performing a flash update for a device. The intention is to support the ability to control the behavior of overwriting the configuration and identifying fields in the Intel ice device flash update process. This is necessary as the firmware layout for the ice device includes some settings and configuration within the same flash section as the main firmware binary. This series, and the accompanying iproute2 series, introduce support for the attribute. Once applied, the overwrite support can be be invoked via devlink: # overwrite settings devlink dev flash pci/0000:af:00.0 file firmware.bin overwrite settings # overwrite identifiers and settings devlink dev flash pci/0000:af:00.0 file firmware.bin overwrite settings overwrite identifiers To aid in the safe addition of new parameters, first some refactoring is done to the .flash_update function: its parameters are converted from a series of function arguments into a structure. This makes it easier to add the new parameter without changing the signature of the .flash_update handler in the future. Additionally, a "supported_flash_update_params" field is added to devlink_ops. This field is similar to the ethtool "supported_coalesc_params" field. The devlink core will now check that the DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT bit is set before forwarding the component attribute. Similarly, the new overwrite attribute will also require a supported bit. Doing these refactors will aid in adding any other attributes in the future, and creates a good pattern for other interfaces to use in the future. By requiring drivers to opt-in, we reduce the risk of accidentally breaking drivers when ever we add an additional parameter. We also reduce boiler plate code in drivers which do not support the parameters. Cc: Jiri Pirko <j...@mellanox.com> Cc: Jakub Kicinski <k...@kernel.org> Cc: Jonathan Corbet <cor...@lwn.net> Cc: Michael Chan <michael.c...@broadcom.com> Cc: Bin Luo <luob...@huawei.com> Cc: Saeed Mahameed <sae...@mellanox.com> Cc: Leon Romanovsky <l...@kernel.org> Cc: Ido Schimmel <ido...@mellanox.com> Cc: Danielle Ratson <daniel...@mellanox.com> Changes since v2: * split the conversion to a parameters structure and the addition of the supported fields bitmask into separate patches * separated the iproute2 patches to their own series * provided some examples in the cover letter * use nla_bitfield32 instead of a straight u32 Jacob Keller (4): devlink: check flash_update parameter support in net core devlink: convert flash_update to use params structure devlink: introduce flash update overwrite mask ice: add support for flash update overwrite mask .../networking/devlink/devlink-flash.rst | 29 +++++++++++++ Documentation/networking/devlink/ice.rst | 31 ++++++++++++++ .../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 19 ++++----- .../net/ethernet/huawei/hinic/hinic_devlink.c | 8 +--- drivers/net/ethernet/intel/ice/ice_devlink.c | 34 ++++++++++----- .../net/ethernet/intel/ice/ice_fw_update.c | 16 ++++++- .../net/ethernet/intel/ice/ice_fw_update.h | 2 +- .../net/ethernet/mellanox/mlx5/core/devlink.c | 8 +--- drivers/net/ethernet/mellanox/mlxsw/core.c | 6 +-- drivers/net/ethernet/mellanox/mlxsw/core.h | 2 +- .../net/ethernet/mellanox/mlxsw/spectrum.c | 7 +--- .../net/ethernet/netronome/nfp/nfp_devlink.c | 9 ++-- drivers/net/netdevsim/dev.c | 21 +++++++--- drivers/net/netdevsim/netdevsim.h | 1 + include/net/devlink.h | 35 +++++++++++++++- include/uapi/linux/devlink.h | 24 +++++++++++ net/core/devlink.c | 42 +++++++++++++++---- .../drivers/net/netdevsim/devlink.sh | 21 ++++++++++ 18 files changed, 247 insertions(+), 68 deletions(-) base-commit: 06a4ec1d9dc652e17ee3ac2ceb6c7cf6c2b75cdd -- 2.28.0.218.ge27853923b9d.dirty
