Andrew Morton <[EMAIL PROTECTED]> wrote: >On Mon, 26 Mar 2007 21:50:01 -0800 [EMAIL PROTECTED] wrote: > >> Replace system timer with work queue in monitor functions. The reason for >> this change is that bonding handlers calls various sleeping functions from >> the timer handler which is not allowed. Because we cannot share the main >> workqueue threads (rtnl_lock is used also in linkwatch_event) - new bond >> workqueue thread is created. > >I have a note here that this patch needs additional work. > >I forget what it was, there has since been no followup and hence I shall now >drop this patch.
Andy Gospodarek <[EMAIL PROTECTED]> and I have been working off list to come up with a comprehensive scheme to resolve the various locking problems in bonding all at once, rather than piecemeal. Currently, we believe we've identified all of the problem areas, have worked up a set of locking rules, and are now hashing out an implementation that (hopefully) doesn't suck. The patch referenced above is more or less a functional subset of the work we're doing, in that we'll also be moving the timers to workqueues. Andy, anything to add? -J --- -Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html