With this patch applied, I no longer experience the kernel warning messages.
Tested-by: Chris Healy <cphe...@gmail.com>
On Sun, Aug 16, 2020 at 12:27 PM Andrew Lunn <and...@lunn.ch> wrote:
>
> It is possible to trigger this WARN_ON from user space by triggering a
> devlink snapshot with an ID which already exists. We don't need both
> -EEXISTS being reported and spamming the kernel log.
>
> Signed-off-by: Andrew Lunn <and...@lunn.ch>
> ---
> net/core/devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index e674f0f46dc2..e5feb87beca7 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -4063,7 +4063,7 @@ static int __devlink_snapshot_id_insert(struct devlink
> *devlink, u32 id)
> {
> lockdep_assert_held(&devlink->lock);
>
> - if (WARN_ON(xa_load(&devlink->snapshot_ids, id)))
> + if (xa_load(&devlink->snapshot_ids, id))
> return -EEXIST;
>
> return xa_err(xa_store(&devlink->snapshot_ids, id, xa_mk_value(0),
> --
> 2.28.0
>
