Hi! Sorry for that. I'll resubmit v4 and I'll add diff from v1, diff from v2 and diff from v3. I will also add Michal Kubecek.
Adrian On Thu, 13 Aug 2020 at 12:24, Ido Schimmel <ido...@idosch.org> wrote: > > On Thu, Aug 13, 2020 at 10:17:35AM +0300, Adrian Pop wrote: > > The Common Management Interface Specification (CMIS) for QSFP-DD shares > > some similarities with other form factors such as QSFP or SFP, but due to > > the fact that the module memory map is different, the current ethtool > > version is not able to provide relevant information about an interface. > > > > This patch adds QSFP-DD support to ethtool. The changes are similar to > > the ones already existing in qsfp.c, but customized to use the memory > > addresses and logic as defined in the specifications document. > > > > Several functions from qsfp.c could be reused, so an additional parameter > > was added to each and the functions were moved to sff-common.c. > > > > Changelog (diff from v2): > > * Remove functions assuming the existance of page 0x10 and 0x11 > > * Remove structs and constants related to the page 0x10 and 0x11 > > Adrian, you're missing diff from v1 and Signed-off-by tag. > > Please send v4 with these changes. > > And please CC Michal Kubecek <mkube...@suse.cz> on ethtool patches since > he maintains the tool. > > Thanks > > > ---
