On 12.08.20 19:46, Jakub Kicinski wrote: > On Wed, 12 Aug 2020 16:39:50 +0200 Stefan Assmann wrote: >> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c: In function >> ‘i40e_set_vsi_promisc’: >> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1176:14: error: ‘aq_ret’ >> may be used uninitialized in this function [-Werror=maybe-uninitialized] >> i40e_status aq_ret; > > What's your compiler? I don't see it on GCC 10.1.
gcc version 8.3.1 20191121 (Red Hat 8.3.1-5) (GCC) >> In case the code inside the if statement and the for loop does not get >> executed aq_ret will be uninitialized when the variable gets returned at >> the end of the function. > > I think it'd be a better fix to make num_vlans unsigned. Agreed, I'll send a v2 patch later. Thanks for the review Jakub! Stefan
