From: Paul Mackerras <[EMAIL PROTECTED]> Date: Mon, 26 Mar 2007 11:02:22 +1000
> David Miller writes: > > > The PPP generic layer seems to be very careful about it's handling of > > the ->xmit_pending packet. > > Mostly, but I think that this is a genuine leak. > > > I'm really surprised this leak doesn't trigger already via the > > ppp_synctty.c and ppp_async.c drivers, perhaps they do something to > > make sure the transmitter gets purged properly when unregistering and > > therefore ->xmit_pending does not get left non-NULL at unregister > > time. > > At least for ppp_async, I think what saves us is that pppd does a > TCFLSH ioctl when shutting down the link, which calls > ppp_async_flush_output, which calls ppp_output_wakeup. Ok, that makes sense, I'll apply the leak fix for sure especially since I even have your ACK now :-) Thanks for reviewing Paul. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
