On Tue, 11 Aug 2020 16:15:53 +0100
Russell King - ARM Linux admin <li...@armlinux.org.uk> wrote:
> > + if (rollball) {
> > + /* TODO: try to write this to EEPROM */
> > + id.base.extended_cc = SFF8024_ECC_10GBASE_T_SFI;
>
> Should we really be "fixing" vendors EEPROMs for them?
>
Are you reffering to the TODO comment or the id.base.extended_cc
assignment?
If the comment, well, your code does it for cotsworks modules, but I am
actually indifferent.
If the assignment - either this needs to be done or the
sfp_probe_for_phy and sfp_may_have_phy functions have to be changed so
that they check for rollball module by vendor ID.
Marek
