On Fri, Aug 7, 2020 at 3:28 PM Jamal Hadi Salim <j...@mojatatu.com> wrote: > > From: Jamal Hadi Salim <j...@mojatatu.com> > > his classifier, in the same spirit as the tc skb mark classifier, > provides a generic (fast lookup) approach to filter on the hash value > and optional mask. > > like skb->mark, skb->hash could be set by multiple entities in the > datapath including but not limited to hardware offloaded classification > policies, hardware RSS (which already sets it today), XDP, ebpf programs > and even by other tc actions like skbedit and IFE.
Looks like a lot of code duplication with cls_fw, is there any way to reuse the code? And I wonder if it is time to introduce a filter to match multiple skb fields, as adding a filter for each skb field clearly does not scale. Perhaps something like: $TC filter add dev $DEV1 parent ffff: protocol ip prio 3 handle X skb \ hash Y mark Z flowid 1:12 Thanks.
