On Mon, 2020-08-03 at 15:42 -0700, David Miller wrote: > From: Joe Perches <j...@perches.com> > Date: Sat, 01 Aug 2020 08:51:03 -0700 > > > Link status is emitted on multiple lines as it does not use > > KERN_CONT. > > > > Coalesce the multi-part logging into a single line output and > > add missing KERN_<LEVEL> to a couple logging calls. > > > > This also reduces object size. > > > > Signed-off-by: Joe Perches <j...@perches.com> > > The real problem is the whole VELOCITY_PRT() private debug log > control business this driver is doing. > > It should be using the standard netdev logging level infrastructure. > > > + VELOCITY_PRT(MSG_LEVEL_INFO, KERN_INFO "set Velocity > > to forced full mode\n"); > > You can't tell me that this "KERN_INFO blah blah blah" is really > something we should add more of these days, right? > > If you're going to improve this driver's logging code please do > so by having it use the standard interfaces.
The existing code is not great and definitely odd. This is just a bug fix until such time as it's better. VELOCITY_PRT is not just used for debugging. The default is output if MSG_LEVEL_INFO and there's a control for further output. This is just fixing Linus' change for KERN_CONT uses on separate lines from awhile ago. It'd be nice if a via maintainer actually fixed it.
