info cannot be NULL here since its being accessed earlier
in the function: nlmsg_parse(info->nlhdr...). Remove this
redundant NULL check.

Signed-off-by: Gaurav Singh <gaurav1...@gmail.com>
---
 net/ethtool/linkmodes.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/ethtool/linkmodes.c b/net/ethtool/linkmodes.c
index fd4f3e58c6f6..b595d87fa880 100644
--- a/net/ethtool/linkmodes.c
+++ b/net/ethtool/linkmodes.c
@@ -406,8 +406,7 @@ int ethnl_set_linkmodes(struct sk_buff *skb, struct 
genl_info *info)
 
        ret = __ethtool_get_link_ksettings(dev, &ksettings);
        if (ret < 0) {
-               if (info)
-                       GENL_SET_ERR_MSG(info, "failed to retrieve link 
settings");
+               GENL_SET_ERR_MSG(info, "failed to retrieve link settings");
                goto out_ops;
        }
 
-- 
2.17.1

Reply via email to