From: Christoph Hellwig <h...@lst.de> > Sent: 28 July 2020 17:39 > > While the kernel in general is not strict aliasing safe we can trivially > do that in sockptr_is_null without affecting code generation, so always > check the actually assigned union member.
Even with 'strict aliasing' gcc (at least) guarantees that the members of a union alias each other. It is about the only way so safely interpret a float as an int. So when sockptr_t is a union testing either member is enough. When it is a structure the changed form almost certainly adds code. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)