Tue, Jul 28, 2020 at 02:58:02AM CEST, k...@kernel.org wrote: >On Mon, 27 Jul 2020 14:02:21 +0300 Moshe Shemesh wrote: >> Add devlink reload level to allow the user to request a specific reload >> level. The level parameter is optional, if not specified then driver's >> default reload level is used (backward compatible). > >Please don't leave space for driver-specific behavior. The OS is >supposed to abstract device differences away.
But this is needed to maintain the existing behaviour which is different for different drivers. > >Previously the purpose of reload was to activate new devlink params >(with driverinit cmode), now you want the ability to activate new >firmware. Let users specify their intent and their constraints. > >> Reload levels supported are: >> driver: driver entities re-instantiation only. >> fw_reset: firmware reset and driver entities re-instantiation. >> fw_live_patch: firmware live patching only. > >I'm concerned live_patch is not first - it's the lowest impact (since >it's live). Please make sure you clearly specify the expected behavior >for the new API. > >The notion of multi-host is key for live patching, so it has to be >mentioned. > >> Signed-off-by: Moshe Shemesh <mo...@mellanox.com>
