On 24/07/2020 21:32, kernel test robot wrote: > Hi Edward, > > I love your patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-driver-for-EF100-family-NICs-part-1/20200725-000401 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > 1b6687e31a2df9fbdb12d25c1d1d372777bf96a8 > config: microblaze-randconfig-r021-20200725 (attached as .config) > compiler: microblaze-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross > ARCH=microblaze > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <l...@intel.com> > > All error/warnings (new ones prefixed by >>): > >>> drivers/net/ethernet/sfc/siena.c:1021:16: error: '__efx_enqueue_skb' >>> undeclared here (not in a function); did you mean 'efx_enqueue_skb'? > 1021 | .tx_enqueue = __efx_enqueue_skb, > | ^~~~~~~~~~~~~~~~~ > | efx_enqueue_skb Aaaaaargh. Apparently INDIRECT_CALLABLE_DECLARE doesn't declare anything #ifndef CONFIG_RETPOLINE. I presumably misunderstood what it was for, and I should just declare those prototypes normally, without it.
Time to spin a v5... -ed
