On 7/8/20 2:23 AM, Ooi, Joyce wrote:
From: Dalon Westergreen <dalon.westergr...@intel.com>It is more appropriate to set the rx and tx ring size before calling the init function for the dma. Signed-off-by: Dalon Westergreen <dalon.westergr...@intel.com> Signed-off-by: Joyce Ooi <joyce....@intel.com> --- v2: no change v3: no change v4: no change --- drivers/net/ethernet/altera/altera_tse_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c index ec2b36e05c3f..a3749ffdcac9 100644 --- a/drivers/net/ethernet/altera/altera_tse_main.c +++ b/drivers/net/ethernet/altera/altera_tse_main.c @@ -1154,6 +1154,10 @@ static int tse_open(struct net_device *dev) int i; unsigned long int flags;+ /* set tx and rx ring size */+ priv->rx_ring_size = dma_rx_num; + priv->tx_ring_size = dma_tx_num; + /* Reset and configure TSE MAC and probe associated PHY */ ret = priv->dmaops->init_dma(priv); if (ret != 0) { @@ -1196,8 +1200,6 @@ static int tse_open(struct net_device *dev) priv->dmaops->reset_dma(priv);/* Create and initialize the TX/RX descriptors chains. */- priv->rx_ring_size = dma_rx_num; - priv->tx_ring_size = dma_tx_num; ret = alloc_init_skbufs(priv); if (ret) { netdev_err(dev, "DMA descriptors initialization failed\n");
Reviewed-by: Thor Thayer <thor.tha...@linux.intel.com>
