From: hongbo.w...@nxp.com Date: Wed, 22 Jul 2020 13:50:48 +0800 > diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c > index c69d9592a2b7..12b46cb6549c 100644 > --- a/drivers/net/dsa/ocelot/felix.c > +++ b/drivers/net/dsa/ocelot/felix.c > @@ -132,9 +132,13 @@ static void felix_vlan_add(struct dsa_switch *ds, int > port, > { > struct ocelot *ocelot = ds->priv; > u16 flags = vlan->flags; > + struct ocelot_port *ocelot_port = ocelot->ports[port]; > u16 vid; > int err;
Please use reverse christmas tree ordering for local variables.