Thanks for your suggestion! I will change the code. thanks. -----Original Message----- From: Florian Fainelli <f.faine...@gmail.com> Sent: 2020年7月21日 12:57 To: Hongbo Wang <hongbo.w...@nxp.com>; Xiaoliang Yang <xiaoliang.yan...@nxp.com>; allan.niel...@microchip.com; Po Liu <po....@nxp.com>; Claudiu Manoil <claudiu.man...@nxp.com>; Alexandru Marginean <alexandru.margin...@nxp.com>; Vladimir Oltean <vladimir.olt...@nxp.com>; Leo Li <leoyang...@nxp.com>; Mingkai Hu <mingkai...@nxp.com>; and...@lunn.ch; vivien.dide...@gmail.com; da...@davemloft.net; j...@resnulli.us; ido...@idosch.org; k...@kernel.org; vinicius.go...@intel.com; niko...@cumulusnetworks.com; ro...@cumulusnetworks.com; netdev@vger.kernel.org; linux-ker...@vger.kernel.org; horatiu.vul...@microchip.com; alexandre.bell...@bootlin.com; unglinuxdri...@microchip.com; linux-de...@linux.nxdi.nxp.com Subject: [EXT] Re: [PATCH 1/2] net: dsa: Add flag for 802.1AD when adding VLAN for dsa switch and port
Caution: EXT Email On 7/20/2020 3:41 AM, hongbo.w...@nxp.com wrote: > From: "hongbo.wang" <hongbo.w...@nxp.com> > > the following command can be supported: > ip link add link swp1 name swp1.100 type vlan protocol 802.1ad id 100 You should probably include the switch driver that is going to be benefiting from doing these changes in the patch series, provide a cover letter when sending more than one patch, and also combine both the add and delete parts. Since you already have visibility into proto, it may not be necessary at all for now to define a BRIDGE_VLAN_INFO_8021AD bit in order to pass that flag down to DSA for programming the VLAN, just pass proto to dsa_port_vid_add() or a boolean flag which indicates whether this is the customer or service tag that you are trying to program? -- Florian
