From: Chi Song <song....@microsoft.com> Date: Tue, 21 Jul 2020 02:37:42 +0000
> +static ssize_t tx_indirection_show(struct device *dev, > + struct device_attribute *dev_attr, char *buf) > +{ > + struct net_device *ndev = to_net_dev(dev); > + struct net_device_context *ndc = netdev_priv(ndev); > + int index = dev_attr - dev_attr_netvsc_dev_attrs; Reverse christmas tree ordering for local variables please. > +static void netvsc_attrs_init(void) > +{ > + int i; > + char buffer[4]; Likewise.