Re: [PATCH net-next v3] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range

[Shay Agroskin]

Wang Hai <wangha...@huawei.com> writes:

Fix sparse build warning:

drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
 Using plain integer as NULL pointer

Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Wang Hai <wangha...@huawei.com>
Suggested-by: Joe Perches <j...@perches.com>
Acked-by: Shay Agroskin <shay...@amazon.com>
---
v1->v2:

Improve code readability based on Joe Perches's suggestion v2->v3:

 Simplify code based on Joe Perches's suggestion
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c

index 91be3ffa1c5c..3eb63b12dd68 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c

@@ -2190,14 +2190,13 @@ static void ena_del_napi_in_range(struct ena_adapter *adapter,

 static void ena_init_napi_in_range(struct ena_adapter *adapter,
                                   int first_index, int count)
 {
-       struct ena_napi *napi = {0};
        int i;

for (i = first_index; i < first_index + count; i++) {

-               napi = &adapter->ena_napi[i];
+               struct ena_napi *napi = &adapter->ena_napi[i];

netif_napi_add(adapter->netdev,

-                              &adapter->ena_napi[i].napi,
+                              &napi->napi,

ENA_IS_XDP_INDEX(adapter, i) ? ena_xdp_io_poll : ena_io_poll,

                               ENA_NAPI_BUDGET);

Acked-by: Shay Agroskin <shay...@amazon.com>

Thanks a lot for your work