On Thu, 2020-07-16 at 15:26 -0700, Jakub Kicinski wrote: > On Thu, 16 Jul 2020 14:33:18 -0700 Saeed Mahameed wrote: > > From: Tariq Toukan <tar...@mellanox.com> > > > > Use INDIRECT_CALL_2() helper to avoid the cost of the indirect call > > when/if CONFIG_RETPOLINE=y. > > > > Signed-off-by: Tariq Toukan <tar...@mellanox.com> > > Reviewed-by: Maxim Mikityanskiy <maxi...@mellanox.com> > > Signed-off-by: Saeed Mahameed <sae...@mellanox.com> > > Are these expected? > > drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c:251:29: warning: > symbol 'mlx5e_xmit_xdp_frame_check_mpwqe' was not declared. Should it > be static? > drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c:306:29: warning: > symbol 'mlx5e_xmit_xdp_frame_check' was not declared. Should it be > static? > drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c:251:29: warning: no > previous prototype for ‘mlx5e_xmit_xdp_frame_check_mpwqe’ [-Wmissing- > prototypes] > 251 | INDIRECT_CALLABLE_SCOPE int > mlx5e_xmit_xdp_frame_check_mpwqe(struct mlx5e_xdpsq *sq) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c:306:29: warning: no > previous prototype for ‘mlx5e_xmit_xdp_frame_check’ [-Wmissing- > prototypes] > 306 | INDIRECT_CALLABLE_SCOPE int mlx5e_xmit_xdp_frame_check(struct > mlx5e_xdpsq *sq) > |
No, missing INDIRECT_CALLABLE_DECLARE() I guess, will fix this up. Thanks fore the report.
