Hi Edward, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Edward-Cree/sfc_ef100-driver-for-EF100-family-NICs-part-1/20200716-210541 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 59632b220f2d61df274ed3a14a204e941051fdad config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): mips-linux-ld: drivers/net/ethernet/sfc/ef100_nic.o: in function `efx_mcdi_sensor_event': >> ef100_nic.c:(.text.efx_mcdi_sensor_event+0x0): multiple definition of >> `efx_mcdi_sensor_event'; >> drivers/net/ethernet/sfc/mcdi_mon.o:mcdi_mon.c:(.text.efx_mcdi_sensor_event+0x0): >> first defined here >> mips-linux-ld: >> drivers/net/ethernet/sfc/ef100_netdev.o:(.bss.efx_separate_tx_channels+0x0): >> multiple definition of `efx_separate_tx_channels'; >> drivers/net/ethernet/sfc/efx.o:(.bss.efx_separate_tx_channels+0x0): first >> defined here >> mips-linux-ld: >> drivers/net/ethernet/sfc/ef100_ethtool.o:(.data.efx_driver_name+0x0): >> multiple definition of `efx_driver_name'; >> drivers/net/ethernet/sfc/ethtool.o:(.data.efx_driver_name+0x0): first >> defined here mips-linux-ld: drivers/net/ethernet/sfc/ef100_rx.o: in function `__efx_rx_packet': >> ef100_rx.c:(.text.__efx_rx_packet+0x0): multiple definition of >> `__efx_rx_packet'; >> drivers/net/ethernet/sfc/rx.o:rx.c:(.text.__efx_rx_packet+0x0): first >> defined here mips-linux-ld: drivers/net/ethernet/sfc/ef100_tx.o: in function `efx_enqueue_skb_tso': >> ef100_tx.c:(.text.efx_enqueue_skb_tso+0x0): multiple definition of >> `efx_enqueue_skb_tso'; >> drivers/net/ethernet/sfc/tx_tso.o:tx_tso.c:(.text.efx_enqueue_skb_tso+0x0): >> first defined here mips-linux-ld: drivers/net/ethernet/sfc/ef100_tx.o: in function `efx_enqueue_skb': >> ef100_tx.c:(.text.efx_enqueue_skb+0x0): multiple definition of >> `efx_enqueue_skb'; >> drivers/net/ethernet/sfc/tx.o:tx.c:(.text.efx_enqueue_skb+0x0): first >> defined here --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip