On Mon, Jul 13, 2020 at 06:54:43AM -0400, Michael S. Tsirkin wrote:
> On Fri, Jul 10, 2020 at 02:12:43PM +0200, Stefano Garzarella wrote:
> > Commit 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free
> > on the_virtio_vsock") starts to use RCU to protect 'the_virtio_vsock'
> > pointer, but we forgot to annotate it.
> >
> > This patch adds the annotation to fix the following sparse errors:
> >
> > net/vmw_vsock/virtio_transport.c:73:17: error: incompatible types in
> > comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:73:17: struct virtio_vsock
> > [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:73:17: struct virtio_vsock *
> > net/vmw_vsock/virtio_transport.c:171:17: error: incompatible types in
> > comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:171:17: struct virtio_vsock
> > [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:171:17: struct virtio_vsock *
> > net/vmw_vsock/virtio_transport.c:207:17: error: incompatible types in
> > comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:207:17: struct virtio_vsock
> > [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:207:17: struct virtio_vsock *
> > net/vmw_vsock/virtio_transport.c:561:13: error: incompatible types in
> > comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:561:13: struct virtio_vsock
> > [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:561:13: struct virtio_vsock *
> > net/vmw_vsock/virtio_transport.c:612:9: error: incompatible types in
> > comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:612:9: struct virtio_vsock
> > [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:612:9: struct virtio_vsock *
> > net/vmw_vsock/virtio_transport.c:631:9: error: incompatible types in
> > comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:631:9: struct virtio_vsock
> > [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:631:9: struct virtio_vsock *
> >
> > Fixes: 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free on
> > the_virtio_vsock")
> > Reported-by: Michael S. Tsirkin <m...@redhat.com>
> > Signed-off-by: Stefano Garzarella <sgarz...@redhat.com>
>
>
> Acked-by: Michael S. Tsirkin <m...@redhat.com>
>
> who's merging this? Dave?
I think so, but I forgot the 'net' tag :-(
I'll wait to see if Dave will queue this, otherwise I'll resend with
the 'net' tag.
Thanks,
Stefano
