From: Robert Olsson <[EMAIL PROTECTED]> Date: Fri, 16 Mar 2007 13:38:31 +0100
> > Hello, Just discussed this Patrick... > > We have two users of trie_leaf_remove, fn_trie_flush and fn_trie_delete > both are holding RTNL. So there shouldn't be need for this preempt stuff. > This is assumed to a leftover from an older RCU-take. > > > Mhh .. I think I just remembered something - me incorrectly suggesting > > to add it there while we were talking about this at OLS :) IIRC the > > idea was to make sure tnode_free (which at that time didn't use > > call_rcu) wouldn't free memory while still in use in a rcu read-side > > critical section. It should have been synchronize_rcu of course, > > but with tnode_free using call_rcu it seems to be completely > > unnecessary. So I guess we can simply remove it. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> > Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
