Sent from my iPhone
> On Jul 9, 2020, at 11:23 PM, Jakub Kicinski <k...@kernel.org> wrote: > > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > >> On Thu, 9 Jul 2020 22:05:00 +0300 akiy...@amazon.com wrote: >> From: Arthur Kiyanovski <akiy...@amazon.com> >> >> Add support for traffic mirroring, where the hardware reads the >> buffer from the instance memory directly. >> >> Traffic Mirroring needs access to the rx buffers in the instance. >> To have this access, this patch: >> 1. Changes the code to map and unmap the rx buffers bidirectionally. >> 2. Enables the relevant bit in driver_supported_features to indicate >> to the FW that this driver supports traffic mirroring. >> >> Signed-off-by: Arthur Kiyanovski <akiy...@amazon.com> > > Any more information? You map rx buffers bidirectionally, doesn't mean > the instance doesn't modify the buffer causing the mirror to see a > modified frame.. Does the instance wait somehow for the mirror to be > done, or is the RX completion not generated until mirror operation is > done? Rx completion is not generated until mirroring is done