On Sun, Jul 5, 2020 at 11:33 PM Stephen Hemminger
<step...@networkplumber.org> wrote:
>
> On Mon, 29 Jun 2020 13:13:04 +0530
> Vasundhara Volam <vasundhara-v.vo...@broadcom.com> wrote:
>
> > Add support for reading board serial_number to devlink info
> > subcommand. Example:
> >
> > $ devlink dev info pci/0000:af:00.0 -jp
> > {
> > "info": {
> > "pci/0000:af:00.0": {
> > "driver": "bnxt_en",
> > "serial_number": "00-10-18-FF-FE-AD-1A-00",
> > "board.serial_number": "433551F+172300000",
> > "versions": {
> > "fixed": {
> > "board.id": "7339763 Rev 0.",
> > "asic.id": "16D7",
> > "asic.rev": "1"
> > },
> > "running": {
> > "fw": "216.1.216.0",
> > "fw.psid": "0.0.0",
> > "fw.mgmt": "216.1.192.0",
> > "fw.mgmt.api": "1.10.1",
> > "fw.ncsi": "0.0.0.0",
> > "fw.roce": "216.1.16.0"
> > }
> > }
> > }
> > }
> > }
>
> Although this is valid JSON, many JSON style guides do not allow
> for periods in property names. This is done so libraries can use
> dot notation to reference objects.
Okay, I will modify the name to board_serial_number and resend the
patch. Thanks.
>
> Also the encoding of PCI is problematic
>
>
